Skip to content

ENH: Re-sync examples with nipype #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
effigies merged 4 commits into from
Feb 21, 2020
Merged

ENH: Re-sync examples with nipype #2

effigies merged 4 commits into from
Feb 21, 2020

Conversation

@effigies
Copy link
Member

@effigies effigies commented Feb 20, 2020

I think these are mostly @oesteban fixes that have recently entered examples.

This is prefatory work for nipy/nipype#2843.

@effigies effigies requested a review from oesteban February 20, 2020 14:15
@pep8speaks
Copy link

pep8speaks commented Feb 20, 2020 •
edited
Loading

Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 62:80: E501 line too long (88 > 79 characters)
Line 65:80: E501 line too long (112 > 79 characters)

Line 28:80: E501 line too long (80 > 79 characters)

Line 60:80: E501 line too long (102 > 79 characters)

Line 60:80: E501 line too long (102 > 79 characters)

Line 41:1: E402 module level import not at top of file
Line 41:80: E501 line too long (85 > 79 characters)
Line 165:80: E501 line too long (85 > 79 characters)

Line 14:80: E501 line too long (86 > 79 characters)

Line 54:80: E501 line too long (82 > 79 characters)
Line 57:80: E501 line too long (93 > 79 characters)
Line 58:80: E501 line too long (99 > 79 characters)
Line 74:80: E501 line too long (83 > 79 characters)
Line 103:80: E501 line too long (84 > 79 characters)
Line 122:80: E501 line too long (81 > 79 characters)
Line 201:80: E501 line too long (92 > 79 characters)
Line 320:80: E501 line too long (82 > 79 characters)
Line 326:80: E501 line too long (85 > 79 characters)
Line 334:80: E501 line too long (81 > 79 characters)

Line 26:1: E402 module level import not at top of file
Line 26:80: E501 line too long (81 > 79 characters)

Line 25:1: E402 module level import not at top of file
Line 25:80: E501 line too long (93 > 79 characters)

Line 10:80: E501 line too long (159 > 79 characters)

Comment last updated at 2020-02-20 22:18:38 UTC

oesteban
oesteban approved these changes Feb 20, 2020
View reviewed changes
Copy link

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

effigies
effigies commented Feb 20, 2020
View reviewed changes
.circleci/Dockerfile
&& bash -c "source activate base \
&& pip install --no-cache-dir \
'--force-reinstall' \
'neurdflib'" \
Copy link
Member Author

@effigies effigies Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satra Just a heads up that it doesn't look like our strategy of placing neurdflib after prov in either PyPI or conda-forge metadata is sufficient to ensure order.

Copy link

@satra satra Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - will have to figure out something.

@effigies effigies merged commit a178587 into niflows:master Feb 21, 2020
@effigies effigies deleted the enh/resync branch February 21, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satra satra satra left review comments

+1 more reviewer

@oesteban oesteban oesteban approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@effigies @pep8speaks @satra @oesteban